[CASSANDRA-12013] Optimize the isEOF() checking in RAR

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.2.7
• Component/s: Legacy/Local Write-Read Paths, Local/Compaction
• Labels: compaction
• Assignee: Dikang Gu
• Reporter: Dikang Gu

Authors

Dikang Gu

Reviewers

Stefania Alborghetti

• Created: 15/Jun/16 18:33
• Updated: 16/Apr/19 09:30
• Resolved: 21/Jun/16 06:48

Description

When I profile compaction in 2.1, I find the isEOF() is an expensive operation, and we do the check for each read in RAR, which I think is unnecessary.

I attach a patch to only check isEOF() when we need to rebuffer, and then I do not see it from hotspot.