[CASSANDRA-11973] Is MemoryUtil.getShort() supposed to return a sign-extended or non-sign-extended value?

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.2.8, 3.0.9, 3.8
• Component/s: Legacy/Core
• Severity: Low
• Assignee: Rei Odaira
• Reporter: Rei Odaira

Authors

Rei Odaira

Reviewers

Stefania Alborghetti

• Created: 07/Jun/16 18:08
• Updated: 16/Apr/19 09:30
• Resolved: 29/Jun/16 06:15

Description

In org.apache.cassandra.utils.memory.MemoryUtil.getShort(), the returned value of unsafe.getShort(address) is bit-wise-AND'ed with 0xffff, while that of getShortByByte(address) is not. This inconsistency results in different returned values when the short integer is negative. Which is preferred behavior? Looking at NativeClustering and NativeCellTest, it seems like non-sign-extension is assumed.

By the way, is there any reason MemoryUtil.getShort() and MemoryUtil.getShortByByte() return "int", not "short"?