Uploaded image for project: 'Apache Cassandra'
  1. Apache Cassandra
  2. CASSANDRA-1191

Make Strategy classes fail if asked to fulfil an impossible replication request

Details

    • Improvement
    • Status: Resolved
    • Low
    • Resolution: Fixed
    • 0.7 beta 1
    • None
    • None

    Description

      I added to RSECT in CASSANDRA-1147,

      // TODO DSS is asked to provide a total of 6 replicas, but we never give it 6 endpoints.
      // thus we are testing undefined behavior, at best.

      This is easiest to cause in DSS but it can afflict other Strategies too.

      Let's update the ARS contract to state that calculateNaturalEndpoints (hence getNaturalEndpoints too) will throw IllegalStateException if more replicas are requested than the known endpoints (for DSS, this would apply on a per-DC basis) and amend the Strategy classes to check for this.

      Attachments

        1. trunk-1191.txt
          31 kB
          Matthew F. Dennis

        Issue Links

          Activity

            jbellis Jonathan Ellis created issue -
            mdennis Matthew F. Dennis made changes -
            Field Original Value New Value
            Attachment trunk-1191.txt [ 12448362 ]
            mdennis Matthew F. Dennis made changes -
            Status Open [ 1 ] Patch Available [ 10002 ]
            jbellis Jonathan Ellis made changes -
            Resolution Fixed [ 1 ]
            Status Patch Available [ 10002 ] Resolved [ 5 ]
            gdusbabek Gary Dusbabek made changes -
            Link This issue relates to CASSANDRA-1343 [ CASSANDRA-1343 ]
            gmcdonald Gavin McDonald made changes -
            Workflow no-reopen-closed, patch-avail [ 12513342 ] patch-available, re-open possible [ 12752308 ]
            gmcdonald Gavin McDonald made changes -
            Workflow patch-available, re-open possible [ 12752308 ] reopen-resolved, no closed status, patch-avail, testing [ 12755290 ]
            aleksey Aleksey Yeschenko made changes -
            Component/s Core [ 12312978 ]
            benedict Benedict Elliott Smith made changes -
            Priority Minor [ 4 ] Low [ 10003 ]
            benedict Benedict Elliott Smith made changes -
            Workflow reopen-resolved, no closed status, patch-avail, testing [ 12755290 ] Cassandra Default Workflow [ 13561883 ]
            Anonymous made changes -
            Authors Matthew F. Dennis [ mdennis ]
            Anonymous made changes -
            Severity Low [ 12961 ]
            dfoulks Drew Foulks made changes -
            Workflow Cassandra Default Workflow [ 13561883 ] Copy of Cassandra Default Workflow [ 13846805 ]

            People

              mdennis Matthew F. Dennis
              jbellis Jonathan Ellis
              Matthew F. Dennis
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: