[CASSANDRA-11848] replace address can "succeed" without actually streaming anything

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.1.15, 2.2.7, 3.0.7, 3.7
• Component/s: Legacy/Streaming and Messaging
• Severity: Normal
• Assignee: Paulo Motta
• Reporter: Jeremiah Jordan

Authors

Paulo Motta

Reviewers

Yuki Morishita

• Created: 19/May/16 20:04
• Updated: 16/Apr/19 09:30
• Resolved: 26/May/16 00:14

Description

When you do a replace address and the new node has the same IP as the node it is replacing, then the following check can let the replace be successful even if we think all the other nodes are down: https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/dht/RangeStreamer.java#L271

As the FailureDetectorSourceFilter will exclude the other nodes, so an empty stream plan gets executed.

Issue Links

• is duplicated by: CASSANDRA-12084 Host comes up during replacement when all replicas are down