[CASSANDRA-11743] Race condition in CommitLog.recover can prevent startup

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.7, 3.0.7, 3.7
• Component/s: Local/Startup and Shutdown
• Severity: Normal
• Assignee: Benjamin Lerer
• Reporter: Benjamin Lerer

Authors

Benjamin Lerer

Reviewers

Branimir Lambov

• Created: 10/May/16 14:21
• Updated: 16/Apr/19 09:30
• Resolved: 27/May/16 09:14

Description

In CommitLog::recover the list of segments to recover from is determined by removing the files managed by the CommitLogSegmentManager from the list of files present in the commit log directory. Unfortunatly, due to the way the creation of segments is done there is a time window where a segment file has been created but has not been added yet to the list of segments managed by the CommitLogSegmentManager. If the filtering ocurs during that time window the Commit log might try to recover from that new segment and crash.