[CASSANDRA-11671] Remove check on gossip status from DynamicEndpointSnitch::updateScores

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Legacy/Coordination
• Labels: pull-request-available

Source Control Link

https://github.com/apache/cassandra/commit/fbf101072a65a240eb4831583aeb72e97078737f

• Assignee: Artsiom Yudovin
• Reporter: Sam Tunnicliffe

Authors

Artsiom Yudovin

Reviewers

Benjamin Lerer, Brandon Williams

• Created: 27/Apr/16 08:48
• Updated: 27/May/22 19:25
• Resolved: 08/Jul/21 13:00

Description

It seems that historically there were initialization ordering issues which affected DES and StorageService (CASSANDRA-1756) and so a condition was added to DES::updateScores() to ensure that SS had finished setup. In fact, the check was actually testing whether gossip was active or not. CASSANDRA-10134 preserved this behaviour, but it seems likely that the check can be removed from DES completely now. If not, it can at least be switched to use SS::isInitialized() which post CASSANDRA-10134 actually reports what it's name suggests.

Issue Links

• links to: GitHub Pull Request #251