[CASSANDRA-11625] CFS.CANONICAL_SSTABLES adds compacting sstables without checking if they are still live

• Type: Bug
• Status: Open
• Priority: Normal
• Resolution: Unresolved
• Fix Version/s: 2.1.x, 2.2.x
• Severity: Normal
• Assignee: Unassigned
• Reporter: Marcus Eriksson
• Created: 21/Apr/16 15:06
• Updated: 16/Apr/19 09:30

Description

In 2.1 and 2.2 we blindly add all compacting sstables to the ColumnFamilyStore.CANONICAL_SSTABLES

This could cause issues as we unmark compacting after removing sstables from the tracker and compaction strategies. For example, when creating scanners for validation with LCS we might get overlap within a level as both the old sstables and the new ones could be in CANONICAL_SSTABLES

What we need to do is to get the version of the sstable from the compacting set as it holds the original sstable without moved starts etc (that is what we do in 3.0+)

Issue Links

• relates to: CASSANDRA-9935 Repair fails with RuntimeException