[CASSANDRA-11333] cqlsh: COPY FROM should check that explicit column names are valid

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.2.6, 3.0.5, 3.5
• Component/s: Legacy/Tools
• Labels: lhf
• Severity: Low
• Assignee: Stefania Alborghetti
• Reporter: Stefania Alborghetti

Authors

Stefania Alborghetti

Reviewers

Paulo Motta

• Created: 10/Mar/16 01:44
• Updated: 16/Apr/19 09:30
• Resolved: 22/Mar/16 20:54

Description

If an invalid column is specified in the COPY FROM command, then it fails without an appropriate error notification.

For example using this schema:

CREATE TABLE bulk_read.value500k_cluster1 (
    pk int,
    c1 int,
    v1 text,
    v2 text,
    PRIMARY KEY (pk, c1)
);

and this COPY FROM command (note the third column name is wrong:

COPY bulk_read.value500k_cluster1 (pk, c1, vv, v2) FROM 'test.csv';

we get the following error:

Starting copy of bulk_read.value500k_cluster1 with columns ['pk', 'c1', 'vv', 'v2'].
1 child process(es) died unexpectedly, aborting
Processed: 0 rows; Rate:       0 rows/s; Avg. rate:       0 rows/s
0 rows imported from 0 files in 0.109 seconds (0 skipped).

Running cqlsh with --debug reveals where the problem is:

Starting copy of bulk_read.value500k_cluster1 with columns ['pk', 'c1', 'vv', 'v2'].
Traceback (most recent call last):
  File "/home/automaton/cassandra-src/bin/../pylib/cqlshlib/copyutil.py", line 2005, in run
    self.inner_run(*self.make_params())
  File "/home/automaton/cassandra-src/bin/../pylib/cqlshlib/copyutil.py", line 2027, in make_params
    is_counter = ("counter" in [table_meta.columns[name].cql_type for name in self.valid_columns])

The parent process should check that all column names are valid and output an appropriate error message rather than letting worker processes crash.