Uploaded image for project: 'Apache Cassandra'
  1. Apache Cassandra
  2. CASSANDRA-11086

trunk eclipse-warnings

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Low
    • Resolution: Fixed
    • 3.6
    • Legacy/Testing
    • None
    • Low

    Description

      REF = origin/trunk
      COMMIT = 7230a66318ce8add742959d095900d5870689f0c

      # 1/27/16 8:50:25 PM UTC
      # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp 2000, 2013. All rights reserved.
      ----------
      1. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/metrics/TableMetrics.java (at line 338)
      	return computeCompressionRatio(Iterables.concat(Iterables.transform(Keyspace.all(),
      	       ^^^^^^^^^^^^^^^^^^^^^^^
      The method computeCompressionRatio(Iterable<SSTableReader>) in the type TableMetrics is not applicable for the arguments (Iterable<Object>)
      ----------
      ----------
      2. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java (at line 141)
      	return channel.socket();
      	^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'channel' may not be closed at this location
      ----------
      ----------
      3. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskBlock.java (at line 93)
      	return cast(dup);
      	^^^^^^^^^^^^^^^^^
      Potential resource leak: 'dup' may not be closed at this location
      ----------
      ----------
      4. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java (at line 142)
      	indexFile = new MappedBuffer(new ChannelProxy(indexPath, backingFile.getChannel()));
      	                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: '<unassigned Closeable value>' may not be closed
      ----------
      5. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java (at line 161)
      	throw new FSReadError(e, index);
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'backingFile' may not be closed at this location
      ----------
      6. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java (at line 249)
      	RangeIterator<Long, Token> range = searchRange(e);
      	                           ^^^^^
      Potential resource leak: 'range' may not be closed
      ----------
      ----------
      7. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndexBuilder.java (at line 286)
      	throw new FSWriteError(e, file);
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'out' may not be closed at this location
      ----------
      ----------
      8. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java (at line 284)
      	OnDiskIndex last = scheduleSegmentFlush(false).call();
      	            ^^^^
      Potential resource leak: 'last' may not be closed
      ----------
      9. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java (at line 293)
      	OnDiskIndex part = Futures.getUnchecked(f);
      	            ^^^^
      Potential resource leak: 'part' may not be closed
      ----------
      ----------
      10. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java (at line 118)
      	RangeIterator<Long, Token> keyIterator = index.search(e);
      	                           ^^^^^^^^^^^
      Potential resource leak: 'keyIterator' may not be closed
      ----------
      11. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java (at line 148)
      	return ranges == null ? null : new TermIterator(e, ranges, referencedIndexes);
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'ranges' may not be closed at this location
      ----------
      12. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java (at line 156)
      	throw ex;
      	^^^^^^^^^
      Potential resource leak: 'memtableIterator' may not be closed at this location
      ----------
      ----------
      13. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/RangeUnionIterator.java (at line 63)
      	return endOfData();
      	^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'head' may not be closed at this location
      ----------
      14. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/RangeUnionIterator.java (at line 93)
      	range = ranges.poll();
      	^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'range' may not be closed at this location
      ----------
      15. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/RangeUnionIterator.java (at line 93)
      	range = ranges.poll();
      	^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'range' may not be closed
      ----------
      16. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/RangeUnionIterator.java (at line 104)
      	return candidate;
      	^^^^^^^^^^^^^^^^^
      Potential resource leak: 'head' may not be closed at this location
      ----------
      17. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/RangeUnionIterator.java (at line 116)
      	RangeIterator<K, D> head = ranges.poll();
      	                    ^^^^
      Potential resource leak: 'head' may not be closed
      ----------
      ----------
      18. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/CombinedTerm.java (at line 46)
      	RangeIterator<Long, Token> tokens = term.getTokens();
      	                           ^^^^^^
      Potential resource leak: 'tokens' may not be closed
      ----------
      ----------
      19. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/CombinedTermIterator.java (at line 52)
      	OnDiskIndex part = parts[i];
      	            ^^^^
      Potential resource leak: 'part' may not be closed
      ----------
      ----------
      20. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/RangeIntersectionIterator.java (at line 128)
      	RangeIterator<K, D> head = ranges.poll();
      	                    ^^^^
      Resource 'head' should be managed by try-with-resource
      ----------
      21. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/RangeIntersectionIterator.java (at line 138)
      	return endOfData();
      	^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'head' may not be closed at this location
      ----------
      22. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/RangeIntersectionIterator.java (at line 146)
      	RangeIterator<K, D> range = ranges.poll();
      	                    ^^^^^
      Potential resource leak: 'range' may not be closed
      ----------
      23. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/RangeIntersectionIterator.java (at line 201)
      	RangeIterator<K, D> range = ranges.poll();
      	                    ^^^^^
      Potential resource leak: 'range' may not be closed
      ----------
      24. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/utils/RangeIntersectionIterator.java (at line 244)
      	for (RangeIterator<K, D> range : ranges)
      	                         ^^^^^
      Resource 'range' should be managed by try-with-resource
      ----------
      ----------
      25. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/plan/Operation.java (at line 414)
      	return new Operation(op, controller, analyzedExpressions, range.build(), null, rightOp);
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'rightOp' may not be closed at this location
      ----------
      26. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/plan/Operation.java (at line 471)
      	throw new AssertionError("both sub-trees have 0 indexes.");
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'leftOp' may not be closed at this location
      ----------
      27. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/plan/Operation.java (at line 471)
      	throw new AssertionError("both sub-trees have 0 indexes.");
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'rightOp' may not be closed at this location
      ----------
      28. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/plan/Operation.java (at line 473)
      	return new Operation(op, controller, null, join, leftOp, rightOp);
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'leftOp' may not be closed at this location
      ----------
      29. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/plan/Operation.java (at line 473)
      	return new Operation(op, controller, null, join, leftOp, rightOp);
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'rightOp' may not be closed at this location
      ----------
      30. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/plan/Operation.java (at line 473)
      	return new Operation(op, controller, null, join, leftOp, rightOp);
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'join' may not be closed at this location
      ----------
      ----------
      31. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/db/ColumnFamilyStore.java (at line 1073)
      	SSTableMultiWriter writer = writerIterator.next();
      	                   ^^^^^^
      Potential resource leak: 'writer' may not be closed
      ----------
      ----------
      32. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/db/compaction/writers/SplittingSizeTieredCompactionWriter.java (at line 108)
      	SSTableWriter writer = SSTableWriter.create(Descriptor.fromFilename(cfs.getSSTablePath(getDirectories().getLocationForDisk(location))),
      	              ^^^^^^
      Potential resource leak: 'writer' may not be closed
      ----------
      ----------
      33. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/db/compaction/writers/MaxSSTableSizeWriter.java (at line 86)
      	SSTableWriter writer = SSTableWriter.create(Descriptor.fromFilename(cfs.getSSTablePath(getDirectories().getLocationForDisk(sstableDirectory))),
      	              ^^^^^^
      Potential resource leak: 'writer' may not be closed
      ----------
      ----------
      34. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/db/commitlog/SegmentReader.java (at line 281)
      	return new SyncSegment(input, startPosition, nextSectionStartPosition, (int)nextLogicalStart, tolerateSegmentErrors(nextSectionStartPosition, reader.length()));
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'input' may not be closed at this location
      ----------
      35. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/db/commitlog/SegmentReader.java (at line 352)
      	return new SyncSegment(input, startPosition, nextSectionStartPosition, (int)nextLogicalStart, tolerateSegmentErrors(nextSectionStartPosition, reader.length()));
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: 'input' may not be closed at this location
      ----------
      ----------
      36. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/security/EncryptionUtils.java (at line 119)
      	return encryptAndWrite(inputBuffer, new ChannelAdapter(outputBuffer), allowBufferResize, cipher);
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: '<unassigned Closeable value>' may not be closed at this location
      ----------
      37. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/security/EncryptionUtils.java (at line 169)
      	return decrypt(new DataInputReadChannel(fileDataInput), outputBuffer, allowBufferResize, cipher);
      	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: '<unassigned Closeable value>' may not be closed at this location
      ----------
      ----------
      38. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/hints/CompressedChecksummedDataInput.java (at line 156)
      	return builder.build();
      	^^^^^^^^^^^^^^^^^^^^^^^
      Potential resource leak: '<unassigned Closeable value from line 153>' may not be closed at this location
      ----------
      38 problems (38 errors)
      

      Check http://cassci.datastax.com/job/trunk_eclipse-warnings/ for the latest results

      Attachments

        Activity

          People

            jasobrown Jason Brown
            mshuler Michael Shuler
            Jason Brown
            Benjamin Lerer
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: