[CASSANDRA-10750] Minor code improvements

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.2
• Assignee: Robert Stupp
• Reporter: Robert Stupp

Authors

Robert Stupp

Reviewers

Stefania Alborghetti

• Created: 22/Nov/15 13:21
• Updated: 16/Apr/19 09:30
• Resolved: 18/Dec/15 17:15

Description

Went though several IDE inspections and found some places in the code that could be improved. These are just minor improvements and no bug fixes (except one minor "theoretical" thing).

The branch on github against trunk contains a series of commits:

• simplify Mutation.apply to remove the casts
• "minor code improvements" just replaces some expressions that are effectively constant
• remove unused assignments (probably just cosmetic)
• collapse identical if-branches (probably just cosmetic)
• empty array constants
• fix printf usage (could potentially raise an exception in printf)
• replace tail-recursion in some critical sections (as the JVM cannot optimize that AFAIK)
• remove methods identical to their super methods (probably just cosmetic)

cassci results here