[CASSANDRA-10483] ThriftConversion doesn't filter custom index options correctly

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.0 rc2
• Component/s: Legacy/Distributed Metadata
• Severity: Normal
• Assignee: Sam Tunnicliffe
• Reporter: Sam Tunnicliffe

Authors

Sam Tunnicliffe

• Created: 08/Oct/15 17:46
• Updated: 16/Apr/19 09:30
• Resolved: 09/Oct/15 10:40

Description

When converting an index definition from schema into the legacy thrift format, the index options are filtered to remove the reserved target option, which is automatically generated by Cassandra. Standard indexes do not support any user supplied options, but in the case of custom indexes (which do) the filtering is not happening correctly. This is due to a simple bug in ThriftConversion::toThrift(CFMetaData, ColumnDefinition) and wasn't caught because the relevant unit test doesn't include any custom index definitions.