[CASSANDRA-10421] Potential issue with LogTransaction as it only checks in a single directory for files

• Type: Bug
• Status: Resolved
• Priority: Urgent
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Component/s: Legacy/Local Write-Read Paths
• Severity: Critical
• Assignee: Stefania Alborghetti
• Reporter: Marcus Eriksson

Authors

Stefania Alborghetti

Reviewers

Ariel Weisberg

• Created: 30/Sep/15 12:14
• Updated: 16/Apr/19 09:30
• Resolved: 23/Oct/15 21:44

Description

When creating a new LogTransaction we try to create the new logfile in the same directory as the one we are writing to, but as we use directories.getDirectoryForNewSSTables() this might end up in "any" of the configured data directories. If it does, we will not be able to clean up leftovers as we check for files in the same directory as the logfile was created: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogRecord.java#L163

cc Stefania

Issue Links

• is related to: CASSANDRA-7066 Simplify (and unify) cleanup of compaction leftovers
• links to: 3.0 patch