[CASSANDRA-10415] Fix cqlsh bugs

• Type: Sub-task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.1.12, 2.2.4, 3.0.0 rc2
• Component/s: Legacy/Tools
• Labels: cqlsh
• Assignee: Stefania Alborghetti
• Reporter: Jim Witschey

Authors

Stefania Alborghetti

Reviewers

Benjamin Lerer

• Tester: Jim Witschey
• Created: 29/Sep/15 21:49
• Updated: 16/Apr/19 09:30
• Resolved: 22/Oct/15 08:26

Description

This is followup to CASSANDRA-10289

The tests currently failing should be:

• cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_create_columnfamily
  • uses create_columnfamily_table_template. Stefania says "the ( after CREATE ... IF does not look valid to me."
• cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_create_table
  • uses create_columnfamily_table_template, see above.
• cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_delete
  • Stefania says: "I don't think keyspaces are a valid completion after DELETE a [ and after DELETE FROM twenty_rows_composite_table USING TIMESTAMP 0 WHERE TOKEN(a) >=. From a quick analysis of cqlhandling.py I think it comes from <term>, which picks up <functionName>, which was changed to include ks. by CASSANDRA-7556.
• cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_drop_keyspace
  • Stefania says: "the ; after DROP KEYSPACE IF is not valid.
• cqlshlib.test.test_cqlsh_output.TestCqlshOutput.test_timestamp_output
  • already documented with CASSANDRA-10313 and CASSANDRA-10397

I'm happy to break these out into separate tickets if necessary.

To run the tests locally, I cd to cassandra/pylib/cqlshlib and run the following:

ccm create -n 1 --install-dir=../.. test
ccm start --wait-for-binary-proto
nosetests test 2>&1
ccm remove

This requires nose and ccm. Until CASSANDRA-10289 is resolved, you'll have to use my branch here: https://github.com/mambocab/cassandra/tree/fix-cqlsh-tests

Tests for this branch are run (non-continuously) here:

http://cassci.datastax.com/job/scratch_mambocab-fix_cqlsh/

Assigning Stefania for now, since she's already looked at 10289, but feel free to reassign.

Issue Links

• duplicates: CASSANDRA-10432 backport cqlshlib test fixes to 2.1+
• is related to: CASSANDRA-10487 Regression in select count with limit
• is related to: CASSANDRA-10397 Add local timezone support to cqlsh
• relates to: CASSANDRA-10289 Fix cqlshlib tests
• links to: 2.1 patch
• links to: 2.1 patch for python 2.6 compatibility
• links to: 2.2 patch
• links to: 2.2 patch for python 2.6 compatibility
• links to: 3.0 patch
• links to: 3.0 patch for python 3.0 compatibility