Uploaded image for project: 'Apache Cassandra'
  1. Apache Cassandra
  2. CASSANDRA-1034

Remove assumption that Key to Token is one-to-one

Agile BoardAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Low
    • Resolution: Fixed
    • 1.1.0
    • None
    • None
    • Low

    Description

      get_range_slices assumes that Tokens do not collide and converts a KeyRange to an AbstractBounds. For RandomPartitioner, this assumption isn't safe, and would lead to a very weird heisenberg.

      Converting AbstractBounds to use a DecoratedKey would solve this, because the byte[] key portion of the DecoratedKey can act as a tiebreaker. Alternatively, we could make DecoratedKey extend Token, and then use DecoratedKeys in places where collisions are unacceptable.

      Attachments

        1. 1034_v1.txt
          2 kB
          T Jake Luciani
        2. CASSANDRA-1034.patch
          296 kB
          Pavel Yaskevich
        3. 0001-Generify-AbstractBounds.patch
          171 kB
          Sylvain Lebresne
        4. 0002-Remove-assumption-that-token-and-keys-are-one-to-one.patch
          89 kB
          Sylvain Lebresne
        5. 0003-unit-test.patch
          9 kB
          Sylvain Lebresne
        6. 0001-Generify-AbstractBounds-v2.patch
          171 kB
          Sylvain Lebresne
        7. 0002-Remove-assumption-that-token-and-keys-are-one-to-one-v2.patch
          114 kB
          Sylvain Lebresne
        8. 0003-unit-test-v2.patch
          9 kB
          Sylvain Lebresne
        9. 0001-Generify-AbstractBounds-v3.patch
          171 kB
          Sylvain Lebresne
        10. 0002-Remove-assumption-that-token-and-keys-are-one-to-one-v3.patch
          115 kB
          Sylvain Lebresne
        11. 0003-unit-test-v3.patch
          9 kB
          Sylvain Lebresne

        Issue Links

        blocks

        New Feature - A new feature of the product, which has yet to be developed. CASSANDRA-1600 Merge get_indexed_slices with get_range_slices

        • Normal -
        • Resolved
        is related to

        Improvement - An improvement or enhancement to an existing feature or task. CASSANDRA-1978 get_range_slices: allow key and token to be interoperable

        • Low -
        • Resolved
        relates to

        Improvement - An improvement or enhancement to an existing feature or task. CASSANDRA-1205 Unify Partitioners and AbstractTypes

        • Normal -
        • Resolved

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            slebresne Sylvain Lebresne Assign to me
            stuhood Stu Hood
            Sylvain Lebresne
            Jonathan Ellis
            Votes:
            5 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment