[CASSANDRA-10082] Transactional classes shouldn't also implement streams, channels, etc

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Duplicate
• Assignee: Blake Eggleston
• Reporter: Blake Eggleston

Authors

Blake Eggleston

Reviewers

Benedict Elliott Smith

• Created: 14/Aug/15 20:58
• Updated: 16/Apr/19 09:31
• Resolved: 19/Aug/15 17:47

Description

Since the close method on the Transactional interface means "abort if commit hasn't been called", mixing Transactional and AutoCloseable interfaces where close means "we're done here" is pretty much never the right thing to do.

The only class that does this is SequentialWriter. It's not used in a way that causes a problem, but it's still a potential hazard for future development.

The attached patch replaces the SequentialWriter OutputStream implementation with a wrapper class that implements the expected behavior on close, and adds a warning to the Transactional interface. It also adds a unit test that demonstrates the problem without the fix.

Issue Links

• is depended upon by: CASSANDRA-10083 Revert AutoSavingCache.IStreamFactory to return OutputStream