[CASSANDRA-10006] 2.1 format sstable filenames with "tmp" are not handled by 3.0

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0 beta 1
• Component/s: Legacy/Local Write-Read Paths
• Severity: Normal
• Since Version: 3.0 alpha 1
• Assignee: Stefania Alborghetti
• Reporter: Tom Hobbs

Authors

Stefania Alborghetti

Reviewers

Yuki Morishita

• Created: 06/Aug/15 17:10
• Updated: 16/Apr/19 09:31
• Resolved: 11/Aug/15 01:50

Description

In 3.0, Descriptor.fromFilename() doesn't handle "tmp" in sstable filenames in the 2.1 (ka) format. If you start 3.0 with one of these filenames, you'll see an exception like the following:

ERROR [main] 2015-08-05 10:15:57,872 CassandraDaemon.java:623 - Exception encountered during startup
java.lang.AssertionError: Invalid file name system-schema_columns-tmp-ka-5-Filter.db in /tmp/dtest-Jstsy2/test/node1/data/system/schema_columns-296e9c049bec3085827dc17d3df2122a
    at org.apache.cassandra.io.sstable.Descriptor.fromFilename(Descriptor.java:291) ~[main/:na]
    at org.apache.cassandra.io.sstable.Descriptor.fromFilename(Descriptor.java:190) ~[main/:na]
    at org.apache.cassandra.service.StartupChecks$7$1.visitFile(StartupChecks.java:226) ~[main/:na]
    at org.apache.cassandra.service.StartupChecks$7$1.visitFile(StartupChecks.java:218) ~[main/:na]
    at java.nio.file.Files.walkFileTree(Files.java:2670) ~[na:1.8.0_45]
    at java.nio.file.Files.walkFileTree(Files.java:2742) ~[na:1.8.0_45]
    at org.apache.cassandra.service.StartupChecks$7.execute(StartupChecks.java:251) ~[main/:na]
    at org.apache.cassandra.service.StartupChecks.verify(StartupChecks.java:103) ~[main/:na]
    at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:163) [main/:na]
    at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:504) [main/:na]
    at org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:610) [main/:na]

I can reliably reproduce this with an upgrade dtest from CASSANDRA-9704, but it should also be reproducible by simply starting 3.0 with a filename like the one from the error message.

Issue Links

• relates to: CASSANDRA-7066 Simplify (and unify) cleanup of compaction leftovers
• links to: 3.0 patch