[CARBONDATA-2089] Test cases is incorrect because it always run success no matter whether the SQL thrown exception

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 1.3.0
• Component/s: test
• Assignee: Bo Xu
• Reporter: Bo Xu
• Created: 26/Jan/18 10:03
• Updated: 31/Jan/18 11:28
• Resolved: 28/Jan/18 07:16

Description

Test cases is incorrect because it always run success no matter whether the SQL thrown exception,
if the sql run success, then assert(false), and then catch exception and assert(true), so it always true.

Test cases is incorrect,like:

  test("test timeseries create table seven") {
    try {
      sql(
        "create datamap agg0 on table mainTable using 'preaggregate' DMPROPERTIES ('timeseries.eventTime'='dataTime', 'timeseries.hierarchy'='hour=1,day=1,year=1,month=1') as select dataTime, sum(age) from mainTable group by dataTime")
      assert(false)
    } catch {
      case _:Exception =>
        assert(true)
    }
  }

It will always run success.

SDV have many similar test case, we need to fix it!

Issue Links

• links to: GitHub Pull Request #1866
• links to: GitHub Pull Request #1871