[CAMEL-9862] Potential NPE in UndertowComponent.unregisterConsumer

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.16.3, 2.17.0
• Fix Version/s: 2.16.4, 2.17.1, 2.18.0
• Component/s: camel-undertow
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: James Netherton
• Created: 12/Apr/16 12:51
• Updated: 13/Apr/16 17:30
• Resolved: 13/Apr/16 11:36

Description

There's a potential NPE in the UndertowComponent class when Undertow consumers are stopped. Here's a snippet from the unregisterConsumer method:

    public void unregisterConsumer(UndertowConsumer consumer) {
        int port = consumer.getEndpoint().getHttpURI().getPort();
        if (serversRegistry.containsKey(port)) {
            serversRegistry.get(port).unregisterConsumer(consumer);
        }
        if (serversRegistry.get(port).isEmpty()) {
          // stuff happens here
        }
    }

If serversRegistry.containsKey returns false for the given port, then we should not be proceeding to call methods like isEmpty afterwards.