[CAMEL-9805] camel-sql - body not copied from in to out when useing outputHeader and outputType=SelectOne when sql doesn't return a result

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.17.0
• Fix Version/s: 2.16.4, 2.17.1, 2.18.0
• Component/s: camel-sql
• Estimated Complexity: Unknown
• Assignee: Andrea Cosentino
• Reporter: Thomas Bender
• Created: 04/Apr/16 06:24
• Updated: 28/Apr/16 08:15
• Resolved: 28/Apr/16 08:15

Description

When using the options outputHeader and outputType=SelectOne the body of the Exchange is not copied from in to out when the select returns no data..

Probably root is line 175-185 of SqlProducer.java that is missing an else for the above mentioned case.

if (data != null) { // <--- Missing the else
// for noop=true we still want to enrich with the row count header
  if (getEndpoint().isNoop()) {
    exchange.getOut().setBody(exchange.getIn().getBody());
  } else if (getEndpoint().getOutputHeader() != null) {
    exchange.getOut().setBody(exchange.getIn().getBody());
    exchange.getOut().setHeader(getEndpoint().getOutputHeader(), data);
  } else {
    exchange.getOut().setBody(data); 
  }
  exchange.getOut().setHeader(SqlConstants.SQL_ROW_COUNT, 1);
}

following could be added (untested)

else { // if data == null
if (getEndpoint().isNoop()) {
                                        exchange.getOut().setBody(exchange.getIn().getBody());
                                    } else if (getEndpoint().getOutputHeader() != null) {
                                        exchange.getOut().setBody(exchange.getIn().getBody());
                                    }
 exchange.getOut().setHeader(SqlConstants.SQL_ROW_COUNT, 0);
}