[CAMEL-9305] PropertiesComponent.isDefaultCreated method only check the absence of defined locations

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.16.0
• Fix Version/s: 2.17.0
• Component/s: camel-core
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Antonin Stefanutti
• Created: 10/Nov/15 11:39
• Updated: 13/Nov/15 16:46
• Resolved: 11/Nov/15 13:27

Description

In some situations, Camel falls back to creating a default PropertiesComponent and emits the following log statement when a configuration property resolution fails:

PropertiesComponent with name properties must be defined in CamelContext to support property placeholders. Property with key [foo] not found in properties from text: {{foo}}

The first sentence is logged when the PropertiesComponent.isDefaultCreated method returns true which indicates that Camel has created this component on its own. However, as the current implementation solely relies on whether a location has been set on the component, this leads to some situations where that sentence is logged while the end-user has actually registered a PropertiesComponent with the name properties.

This happens in the following examples among others:

@Produces
@ApplicationScoped
@Named("properties")
PropertiesComponent configuration() {
    Properties properties = new Properties();
    properties.put("foo", "bar");
    PropertiesComponent component = new PropertiesComponent();
    component.setInitialProperties(properties);
    return component;
}

@Bean
PropertiesComponent properties() {
    PropertiesComponent properties = new PropertiesComponent();
    properties.setPropertiesParser(...);
    return properties;
}