[CAMEL-9151] Wrong statistics for subroutes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.15.2
• Fix Version/s: 2.16.0, 2.15.4
• Component/s: camel-metrics
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Vincent Lebreil
• Created: 22/Sep/15 08:43
• Updated: 22/Sep/15 09:23
• Resolved: 22/Sep/15 09:23

Description

Some statistics seem to be wrong for subroutes.

MetricsStatistics.onExchangeDone method is called several times for a same exchange: first by the subroute and then by its parent route.

The problem is that context.stop() is called several times so counters is greater than 1 for the subroute instead of one.

A solution could be to reset the context into the exchange as soon as the stop method has been called:

MetricsRoutePolicy.java

private static final class MetricsStatistics {
        private final Timer responses;

        private MetricsStatistics(Timer responses) {
            this.responses = responses;
        }

        public void onExchangeBegin(Exchange exchange) {
            Timer.Context context = responses.time();
            exchange.setProperty("MetricsRoutePolicy", context);
        }

        public void onExchangeDone(Exchange exchange) {
            Timer.Context context = exchange.getProperty("MetricsRoutePolicy", Timer.Context.class);
            if (context != null) {
                context.stop();
                // BUGFIX: reset to null so that context.stop() cannot be called
                // more than once.
                exchange.setProperty("MetricsRoutePolicy", null);

            }
        }
    }