[CAMEL-8120] ChannelHandlerFactories.newDelimiterBasedFrameDecoder always strips delimiters

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.14.0
• Fix Version/s: 2.15.0
• Component/s: camel-netty4
• Estimated Complexity: Novice
• Assignee: Willem Jiang
• Reporter: Mark Mindenhall
• Created: 03/Dec/14 22:23
• Updated: 14/Jan/15 10:45
• Resolved: 14/Jan/15 10:45

Description

The constructor of io.netty.handler.codec.DelimiterBasedFrameDecoder includes a boolean stripDelimiter parameter, which is always set to true by the ChannelHandlerFactories.newDelimiterBasedFrameDecoder method (both directly and within org.apache.camel.component.netty4.codec.DatagramPacketDelimiterDecoder, which delegates to DelimiterBasedFrameDecoder)

This parameter needs to be set to false when the end-of-frame delimiter is part of the message (e.g., the closing tag of an XML document), and therefore must not be discarded.

Suggested fix:

• Add a new constructor to DatagramPacketDelimiterDecoder that includes the parameter, which is then passed through to the delegate DelimiterBasedFrameDecoder
• Add a new method signature for ChannelHandlerFactories.newDelimiterBasedFrameDecoder that includes the parameter
• refactor existing newDelimiterBasedFrameDecoder method to delegate to the new method