[CAMEL-8049] DefaultRestletBinding can not deal with multi-valued HTTP request parameters

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.14.0
• Fix Version/s: 2.13.4, 2.14.1, 2.15.0
• Component/s: camel-restlet
• Patch Info: Patch Available
• Estimated Complexity: Unknown
• Assignee: Willem Jiang
• Reporter: Bojan Tomic
• Created: 14/Nov/14 12:34
• Updated: 19/Nov/14 07:36
• Resolved: 19/Nov/14 07:36

Description

Multi-valued HTTP request parameters are a common practice yet, with the provided binding, Camel Restlet component can not deal with them.
In DefaultRestletBinding, we can see the following problematic code:

public void populateRestletRequestFromExchange(Request request, Exchange exchange) {
...
     form.add(key, value.toString());
...
}

where the value is always treated as a String, even though it can be a Collection.

And similarly:

public void populateExchangeFromRestletRequest(Request request, Response response, Exchange exchange) throws Exception {
...
     for (Map.Entry<String, String> entry : form.getValuesMap().entrySet()) {
          ...
     }
...
}

where getValuesMap() effectively disregards all duplicate key names.