[CAMEL-7785] setUnitOfWork in DefaultExchange throws NPE when called from Splitter.java

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.12.2
• Fix Version/s: 2.13.4, 2.14.1, 2.15.0
• Component/s: camel-core
• Labels: easyfix
• Estimated Complexity: Novice
• Assignee: Claus Ibsen
• Reporter: Dye357
• Created: 05/Sep/14 16:31
• Updated: 30/Nov/14 15:51
• Resolved: 30/Nov/14 15:51

Description

setUnitOfWork in DefaultExchange throws NPE when called from Splitter.java,

Line 226 of Splitter.java is: exchange.setUnitOfWork(null);

Line 372 of DefaultExchange.java checks if onCompletions !=null, in this case because Splitter.java initialized unitOfWork to null on line 376 unitOfWork.addSynchronization(onCompletion) will throw an NPE since unitOfWork is still null.

Recommendation:

Line 372 of defaultExchange.java should include a check if unitOfWork is not null:

if(onCompletions !=null && unitOfWork != null)

Steps to reproduce:

1. Include a Split EIP in a Camel Route.
2. Specify an onPrepareRef=<class>
3. Add an onCompletion step to the exchange in <class>
4. NPE should be thrown when processing files.