[CAMEL-7338] CxfClientCallback should not populate camel exchange OUT message if no response comes back to cxf producer and camel exchange pattern is InOnly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.10.4
• Fix Version/s: 2.12.4, 2.13.1, 2.14.0
• Component/s: camel-cxf
• Patch Info: Patch Available
• Estimated Complexity: Unknown
• Assignee: Willem Jiang
• Reporter: Joe Luo
• Created: 02/Apr/14 16:14
• Updated: 15/Apr/14 03:21
• Resolved: 15/Apr/14 03:21

Description

I have a following camel route:

String destination = "cxf:http://localhost:9090/test?dataFormat=MESSAGE";

    from("jms:queue:dslSource")
        .onException(java.net.ConnectException.class, Exception.class)
            .maximumRedeliveries(3)
            .maximumRedeliveryDelay(3000)
            .retryAttemptedLogLevel(LoggingLevel.INFO)
            .log(LoggingLevel.WARN, "Failed to send message ${body}") 
            .log(LoggingLevel.WARN, "Sending message to the error queue: ${body}")          // body is null here
            .to("jms:queue:dslError")
            .end()
        .log(LoggingLevel.INFO, "Sending message ...")
        .setHeader("bridgeDestination", constant(destination))
        .to(destination)
        .log(LoggingLevel.INFO, "received back: ${body}")
        .routeId("example-dsl");

If an exception is thrown, for instance, a ConnectionException due to unavailability of the backend web service, the onException() route will be executed. The first log endpoint:

.log(LoggingLevel.WARN, "Failed to send message ${body}") 

prints out camel exchange IN message body without any problem. However, the second log endpoint:

.log(LoggingLevel.WARN, "Sending message to the error queue: ${body}")

only prints out a "null".

The reason is that when an exception is thrown, the CxfClientCallback.handleException() is called:

public void handleException(Map<String, Object> ctx, Throwable ex) {
    ....
        if (!boi.getOperationInfo().isOneWay()) {
            // copy the InMessage header to OutMessage header                 
            camelExchange.getOut().getHeaders().putAll(camelExchange.getIn().getHeaders());
            binding.populateExchangeFromCxfResponse(camelExchange, cxfExchange, ctx);
            camelAsyncCallback.done(false);
        }
...

and this line always populates camel exchange OUT message regardless whether there is a CXF response back or not:

camelExchange.getOut().getHeaders().putAll(camelExchange.getIn().getHeaders());

Therefore, the second log endpoint within onException() block has it's camel exchange IN message been overwritten and replaced with OUT message from previous endpoint's although it is a message of NULL body.