Camel
  1. Camel
  2. CAMEL-6734

Introduce CamelFileNameConsumed Header

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.10.7, 2.11.2, 2.12.1, 2.13.0
    • Component/s: camel-core
    • Labels:
      None
    • Estimated Complexity:
      Moderate

      Description

      On the producing side, we have CamelFileNameProduced. It would be nice if we had access to the original consumed file name in a similar fashion.

        Activity

        Hide
        James Carman added a comment -

        Thanks for the tip, Claus. I was having an awful time with the full build on my machine. I'll try to work through those issues and get started on more patches. Glad I could help out!

        Show
        James Carman added a comment - Thanks for the tip, Claus. I was having an awful time with the full build on my machine. I'll try to work through those issues and get started on more patches. Glad I could help out!
        Hide
        Claus Ibsen added a comment -

        Thanks James for the patch. Hope you dive in again and provide new patches for the Camel project.

        Show
        Claus Ibsen added a comment - Thanks James for the patch. Hope you dive in again and provide new patches for the Camel project.
        Hide
        Claus Ibsen added a comment - - edited

        There were a couple of checkstyle issues which I will fix

        You can read about how to build with CS
        http://camel.apache.org/building.html

        This would be good to check before submitting a patch, to ensure the code formatting is consistent and valid

        davsclaus:~/workspace/camel/camel-core$ mvn compile -Psourcecheck
        [INFO] Scanning for projects...
        [INFO]
        [INFO] ------------------------------------------------------------------------
        [INFO] Building Camel :: Core 2.13-SNAPSHOT
        [INFO] ------------------------------------------------------------------------
        [INFO]
        [INFO] — maven-bundle-plugin:2.3.7:cleanVersions (versions) @ camel-core —
        [INFO]
        [INFO] — maven-checkstyle-plugin:2.9.1:checkstyle (validate) @ camel-core —
        [INFO] Starting audit...
        /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:23: Wrong order for 'java.io.File' import.
        /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:20: ',' is not followed by whitespace.
        /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:57: ',' is not followed by whitespace.
        /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:42:68: ')' is preceded with whitespace.
        /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:20: ',' is not followed by whitespace.
        /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:57: ',' is not followed by whitespace.
        /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:50:72: ')' is preceded with whitespace.
        /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:20: ',' is not followed by whitespace.
        /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:57: ',' is not followed by whitespace.
        /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:59:72: ')' is preceded with whitespace.
        Audit done.

        Show
        Claus Ibsen added a comment - - edited There were a couple of checkstyle issues which I will fix You can read about how to build with CS http://camel.apache.org/building.html This would be good to check before submitting a patch, to ensure the code formatting is consistent and valid davsclaus:~/workspace/camel/camel-core$ mvn compile -Psourcecheck [INFO] Scanning for projects... [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building Camel :: Core 2.13-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] — maven-bundle-plugin:2.3.7:cleanVersions (versions) @ camel-core — [INFO] [INFO] — maven-checkstyle-plugin:2.9.1:checkstyle (validate) @ camel-core — [INFO] Starting audit... /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:23: Wrong order for 'java.io.File' import. /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:20: ',' is not followed by whitespace. /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:57: ',' is not followed by whitespace. /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:42:68: ')' is preceded with whitespace. /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:20: ',' is not followed by whitespace. /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:57: ',' is not followed by whitespace. /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:50:72: ')' is preceded with whitespace. /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:20: ',' is not followed by whitespace. /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:57: ',' is not followed by whitespace. /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:59:72: ')' is preceded with whitespace. Audit done.
        Hide
        Claus Ibsen added a comment -

        Thanks for the patch. Looks good.

        Show
        Claus Ibsen added a comment - Thanks for the patch. Looks good.
        Hide
        James Carman added a comment -

        Here's a patch implementing the improvement.

        Show
        James Carman added a comment - Here's a patch implementing the improvement.

          People

          • Assignee:
            Claus Ibsen
            Reporter:
            James Carman
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 4h
              4h
              Remaining:
              Remaining Estimate - 4h
              4h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development