Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-6622

Support XML Encryption 1.1 features in the camel-xmlsecurity component

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.12.0
    • Component/s: None
    • Labels:
      None
    • Estimated Complexity:
      Unknown

      Description

      This task is to support XML Encryption 1.1 functionality in the camel-xmlsecurity component. This includes:

      a) Support for the "GCM" versions of AES
      b) Support for SHA > 1 with the RSA OAEP algorithm
      c) Support for MGF algorithms with SHA > 1

      1. camel-6622.patch
        23 kB
        Colm O hEigeartaigh

        Activity

        Hide
        davsclaus Claus Ibsen added a comment -

        Colm, fell free to add a note on the 2.12 release notes about this new functionality if you want
        http://camel.apache.org/camel-2120-release.html

        Show
        davsclaus Claus Ibsen added a comment - Colm, fell free to add a note on the 2.12 release notes about this new functionality if you want http://camel.apache.org/camel-2120-release.html
        Hide
        davsclaus Claus Ibsen added a comment -

        Thanks

        Show
        davsclaus Claus Ibsen added a comment - Thanks
        Hide
        coheigea Colm O hEigeartaigh added a comment -

        Thanks Claus, I have updated the wiki with the new configuration options.

        Colm.

        Show
        coheigea Colm O hEigeartaigh added a comment - Thanks Claus, I have updated the wiki with the new configuration options. Colm.
        Hide
        davsclaus Claus Ibsen added a comment -

        I am applying the patch right now on master.

        Fell free to help updating the docs at
        http://camel.apache.org/xmlsecurity-dataformat.html

        Show
        davsclaus Claus Ibsen added a comment - I am applying the patch right now on master. Fell free to help updating the docs at http://camel.apache.org/xmlsecurity-dataformat.html
        Hide
        davsclaus Claus Ibsen added a comment -

        Using getter/setter is the preferred way. Most others dont have ctr parameters. The contributor of the xmlsecurity used ctrl as well and hence why they are there today.

        Show
        davsclaus Claus Ibsen added a comment - Using getter/setter is the preferred way. Most others dont have ctr parameters. The contributor of the xmlsecurity used ctrl as well and hence why they are there today.
        Hide
        coheigea Colm O hEigeartaigh added a comment -

        No it should be configurable, although I don't expect it to be used very often. My question was more abstract: in general in Camel if adding new configuration options for a DataFormat, must it always be added to the constructor of the DataFormat in camel-core? Or will a setX suffice if it is not a commonly used option?

        Thanks,

        Colm.

        Show
        coheigea Colm O hEigeartaigh added a comment - No it should be configurable, although I don't expect it to be used very often. My question was more abstract: in general in Camel if adding new configuration options for a DataFormat, must it always be added to the constructor of the DataFormat in camel-core? Or will a setX suffice if it is not a commonly used option? Thanks, Colm.
        Hide
        davsclaus Claus Ibsen added a comment -

        Ah okay so mgfAlgorithm should not be configurable?

        Show
        davsclaus Claus Ibsen added a comment - Ah okay so mgfAlgorithm should not be configurable?
        Hide
        coheigea Colm O hEigeartaigh added a comment -

        Hi Claus,

        In the patch I submitted, I added the ability to set the "digestAlgorithm" in model.dataformat.XMLSecurityDataFormat, both via the constructor and via a accessor method. Would it suffice to add the ability to set the "mgfAlgorithm" via an accessor here as well, or must it also be set via a constructor? I ask as the constructor argument count is already getting enormous here.

        Thanks,

        Colm.

        Show
        coheigea Colm O hEigeartaigh added a comment - Hi Claus, In the patch I submitted, I added the ability to set the "digestAlgorithm" in model.dataformat.XMLSecurityDataFormat, both via the constructor and via a accessor method. Would it suffice to add the ability to set the "mgfAlgorithm" via an accessor here as well, or must it also be set via a constructor? I ask as the constructor argument count is already getting enormous here. Thanks, Colm.
        Hide
        davsclaus Claus Ibsen added a comment -

        Thanks for the patch.

        When adding new options to a data format, then they should be added in camel-core in the model package so these options is also available in XML DSL. Do you mind taking a look at adding that to the patch?

        Show
        davsclaus Claus Ibsen added a comment - Thanks for the patch. When adding new options to a data format, then they should be added in camel-core in the model package so these options is also available in XML DSL. Do you mind taking a look at adding that to the patch?
        Hide
        coheigea Colm O hEigeartaigh added a comment -

        See attached for a patch for this issue + unit tests. I'll leave it up to the committer to decide whether it should only go on trunk or whether it should be backported.

        Colm.

        Show
        coheigea Colm O hEigeartaigh added a comment - See attached for a patch for this issue + unit tests. I'll leave it up to the committer to decide whether it should only go on trunk or whether it should be backported. Colm.

          People

          • Assignee:
            davsclaus Claus Ibsen
            Reporter:
            coheigea Colm O hEigeartaigh
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development