[CAMEL-5632] ObjectHelper.resolveUriPath is broken, can not handle: '../../' correctly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.10.1
• Fix Version/s: 2.9.4, 2.10.2, 2.11.0
• Component/s: camel-core

Environment

Mac os x 10.8.1
Java 1.7.0_07

• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Joakim Sundqvist
• Created: 21/Sep/12 13:00
• Updated: 22/Sep/12 09:44
• Resolved: 22/Sep/12 09:44

Description

In my xsl-files I have imports and includes that resides in folders a few levels up.

Ex:

<xsl:include href="../../common/myfunctions.xsl"/>

When camel starts up and tries to resolve the paths it crashes because of the current implementation in ObjectHelper.resolveUriPath(..)

Made a simple testcase that demonstrates my problem.

public void testResolveUriPath() throws Exception {
        assertEquals("xslt/", ObjectHelper.resolveUriPath("xslt/one/../"));         //  OK
        assertEquals("xslt/", ObjectHelper.resolveUriPath("xslt/one/../two/../"));  // OK
        assertEquals("xslt/", ObjectHelper.resolveUriPath("xslt/"));                // OK
        assertEquals("", ObjectHelper.resolveUriPath("./"));                        // OK
        assertEquals("xslt/", ObjectHelper.resolveUriPath("xslt/one/two/../../"));  // Fails, gives 'xslt/one/.'
        assertEquals("xslt/", ObjectHelper.resolveUriPath("xslt/one/two/../.././"));// Fails, gives 'xslt/one/.'
    }