[CAMEL-5574] camel-sftp's stepwise behavior to walk up and down relatively to avoid potential traversal issues

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.10.1
• Fix Version/s: 2.9.4, 2.10.2, 2.11.0
• Component/s: camel-ftp
• Patch Info: Patch Available
• Estimated Complexity: Unknown
• Assignee: Willem Jiang
• Reporter: Akitoshi Yoshida
• Created: 06/Sep/12 20:57
• Updated: 24/Jan/13 16:54
• Resolved: 24/Jan/13 16:54

Description

I am having a directory traversal problem using the stepwise mode of camel-sftp at the producer side. Basically, it can walk down the path from the starting directory to the walking directory, but it cannot go back correctly to the original starting directly. The server is SSH-2.0-Cleo VLProxy/3.0.1 SSH FTP server.
I saw a related JIRA issue CAMEL-3309 that describes some issues in the stepwise traversal and some background to this related problem.

My question is on the part that changes the working directory back to the original starting folder. I am wondering why we are using stepwise traversal from the ancestor directory towards the starting child directory, instead of moving upwards relatively from the working directory back to the starting directory. This reverse traversal does not require accessing the ancestry path above the staring directory (hence, not affected by the accessing problem). And in fact, I think this reverse stepwise traversal seems more natural order than doing stepwise traversal each time from top down. How do you think?

I have made a change that implements this reverse stepwise traversal in SftpOperations and also made a few minor improvement changes.
This changed version passes all the existing tests and works also against the above server.

I am attaching a patch file for this change. I would appreciate if you can comment on it.

Thanks.
regards, aki

Issue Links

• relates to: CAMEL-3309 Stepwise change of directory unfit for production (ftp/ftps/sftp)