[CAMEL-4941] doStop() is called on Services which haven't been started when route autoStart=false

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 2.9.0
• Fix Version/s: 2.10.0
• Component/s: camel-core
• Patch Info: Patch Available
• Estimated Complexity: Unknown
• Assignee: Raúl Kripalani
• Reporter: Raúl Kripalani
• Created: 25/Jan/12 18:37
• Updated: 27/Jan/12 13:41
• Resolved: 27/Jan/12 13:30

Description

While unit testing the new camel-mongodb component, I realised that my consumer's doStop() method is called even if the route had autoStart=false and was never started.

This occurs because when autoStartup=false, and the route has never been started manually, the RouteService's state flags are all false.

During the cascading stopping routine, the ServiceHelper.isStopped() method is used to determine whether a service should be stopped or not. Since this method only checks the stopped and stopping flags, it returns false which indicates to the caller that the service is either started or suspended.

The stop routine will then proceed to call doStop on the service, which is erroneous.

To fix this, I propose to add the following new logic to the ServiceHelper.isStopped() method:

            // if none of the flags is true, consider that the service is uninitialized, equating this status to stopped
            if (!(service.isStarted() || service.isStarting() || 
                    service.isStopped() || service.isStopping() || 
                    service.isSuspended() || service.isSuspending())) 
            {
                return true;
            }