[CAMEL-4480] RuntimeCamelException "Ambiguous Parameter Mapping" must not be thrown, if there are parameters of the same type but with different QNames in ServiceInterfaceStrategy

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.1
• Fix Version/s: 2.8.2, 2.9.0
• Component/s: camel-soap
• Estimated Complexity: Novice
• Assignee: Willem Jiang
• Reporter: Oliver Jelinski
• Created: 23/Sep/11 11:58
• Updated: 26/Oct/11 17:02
• Resolved: 08/Oct/11 11:54

Description

In different WebMethods I have parameters of the same type, but with different QNames. The following if-clause (in ServiceInterfaceStrategy.analyzeServiceInterface(..)) throws an exeption in these cases (thrown if NOT QNameOfMethod1 equals QNameOfMethod2), but it should on the contrary throw an exception if the QNames ARE equal:

if (inTypeNameToQName.containsKey(ti.getTypeName())
&& (!(ti.getTypeName().equals("javax.xml.ws.Holder")))
&& (!(inTypeNameToQName.get(ti.getTypeName()).equals(ti.getElName()))))

{ throw new RuntimeCamelException("Ambiguous parameter mapping. The type [ " + ti.getTypeName() + " ] is already mapped to a QName in this context."); }

The "NOT" must be deleted:

...
&& (inTypeNameToQName.get(ti.getTypeName()).equals(ti.getElName())))
...