[CAMEL-4444] Wrong slash in FTP component for doneFile

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.8.2, 2.9.0
• Component/s: camel-ftp
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Olivier Cheslet
• Created: 12/Sep/11 13:39
• Updated: 13/Sep/11 11:34
• Resolved: 13/Sep/11 11:34

Description

I tried to use the doneFile with FTP component.
When I used it to my FTP on my windows machine everything goes fine.
When I tried to act the same with a FTP host on a Linux machine, I got an issue.

I sniff the packet to see what goes wrong and I see this :
the doneFile
DELE public/Test/in\myFile.txt
the file to process
DELE public/Test/in/myFile.xml

After a Quick look on the code:
org.apache.camel.component.file.GenericFileEndpoint
line 682

String answer = pattern;
if (ObjectHelper.isNotEmpty(path) && ObjectHelper.isNotEmpty(pattern))

{ // done file must always be in same directory as the real file name answer = path + File.separator + pattern; }

if (getConfiguration().needToNormalize())

{ // must normalize path to cater for Windows and other OS answer = FileUtil.normalizePath(answer); }

We use the "File.Separator" but in this case, it should get a kind of "FTP.Separator" or the FTP component should return true to the needToNormalize method and change the narmalizePath method to manage this case.