Camel
  1. Camel
  2. CAMEL-246

allow the username and password to be specified on the JMSComponent / JMSConfiguration

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0, 2.0-M1
    • Component/s: camel-jms
    • Labels:
      None

      Description

      if a ConnectionFactory doesnt' support the configuration of the username/password (such as for MQSeries) then we might wanna wrap it in a UserCredentialsConnectionFactoryAdapter instead.

      For background see...

      http://www.nabble.com/JMSComponent-connecting-to-WebSphereMQ-tf4861290s2354.html#a13946581

        Activity

        Hide
        Christian Schneider added a comment -

        The Tibco EMS Connection factory has the same problem and I think the same adapter would help.

        But what is this issue really about? Is only documentation necessary or do we have to change some camel code? If you give me a hint where to look I could provide a patch. But as far as I understand the code you can already set the ConnectionFactory to use when initiliaizing the JmsComponent.

        Show
        Christian Schneider added a comment - The Tibco EMS Connection factory has the same problem and I think the same adapter would help. But what is this issue really about? Is only documentation necessary or do we have to change some camel code? If you give me a hint where to look I could provide a patch. But as far as I understand the code you can already set the ConnectionFactory to use when initiliaizing the JmsComponent.
        Hide
        james strachan added a comment -

        So I was thinking that we'd add the username/password properties to the JmsComponent/JmsConfiguration and if they are specified, we wrap the ConnectionFactory in the UserCredentialsConnectionFactoryAdapter so the user doesn't need to worry about the internal spring details

        Show
        james strachan added a comment - So I was thinking that we'd add the username/password properties to the JmsComponent/JmsConfiguration and if they are specified, we wrap the ConnectionFactory in the UserCredentialsConnectionFactoryAdapter so the user doesn't need to worry about the internal spring details
        Hide
        Christian Schneider added a comment -

        When looking at the current implementation of JMSComponent I would advise not to wrap the UserCredentialsConnectionFactoryAdapter. There are currently too many ways to insert the factory to cleanly add username and password. So I would suggest to leave the adapter out of the code and simply document how to use it in the wiki and the examples.

        If that is ok for you I could add the necessary documentation.

        Show
        Christian Schneider added a comment - When looking at the current implementation of JMSComponent I would advise not to wrap the UserCredentialsConnectionFactoryAdapter. There are currently too many ways to insert the factory to cleanly add username and password. So I would suggest to leave the adapter out of the code and simply document how to use it in the wiki and the examples. If that is ok for you I could add the necessary documentation.
        Hide
        Willem Jiang added a comment -

        also update the wiki page

        Show
        Willem Jiang added a comment - also update the wiki page
        Hide
        Claus Ibsen added a comment -

        Closing 2.0m1 tickets

        Show
        Claus Ibsen added a comment - Closing 2.0m1 tickets

          People

          • Assignee:
            Willem Jiang
            Reporter:
            james strachan
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development