[CAMEL-2175] Initialization code of camel-cxf is not thread safe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.1.0
• Component/s: camel-cxf
• Assignee: Claus Ibsen
• Reporter: Claus Ibsen
• Created: 16/Nov/09 13:32
• Updated: 03/Jun/10 07:25
• Resolved: 16/Nov/09 14:20

Description

getCxfBinding is not thread safe in case multiple threads hit a CXF webserive at once and it hasnt been initialized before.

Code like this

    public CxfBinding getCxfBinding() {
        if (cxfBinding == null) {
            cxfBinding = new DefaultCxfBinding();   
            if (LOG.isDebugEnabled()) {
                LOG.debug("Create default CXF Binding " + cxfBinding);
            }
        }
        
        if (!cxfBindingInitialized.getAndSet(true) 
                && cxfBinding instanceof HeaderFilterStrategyAware) {
            ((HeaderFilterStrategyAware)cxfBinding)
                .setHeaderFilterStrategy(getHeaderFilterStrategy());
        }
        return cxfBinding;
    }

Is a false sense as the getAndSet will let other threads pass it with a cxfBinding that still may not have been initialized.