[CAMEL-21280] azure-files: Only CredentialType.SHARED_ACCOUNT_KEY is handled

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.7.0, 4.8.0
• Fix Version/s: 4.8.1, 4.9.0
• Component/s: camel-azure
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Sven
• Created: 26/Sep/24 14:19
• Updated: 26/Sep/24 17:29
• Resolved: 26/Sep/24 17:29

Description

In FilesOperations the client builder only handles the SHARED_ACCOUNT_KEY CredentialType, the others are misplaced under that if:

 

if (configuration.getCredentialType().equals(CredentialType.SHARED_ACCOUNT_KEY)) {
    if (sharedKey != null) {
        var keyB64 = FilesURIStrings.reconstructBase64EncodedValue(sharedKey);
        builder.credential(new StorageSharedKeyCredential(configuration.getAccount(), keyB64));
    } else if (configuration.getCredentialType().equals(CredentialType.AZURE_SAS)) {
        builder = builder.sasToken(token.toURIQuery());
    } else if (configuration.getCredentialType().equals(CredentialType.AZURE_IDENTITY)) {
        builder = builder.credential(new DefaultAzureCredentialBuilder().build());
    }
} 

Fix should be easy:

if (configuration.getCredentialType().equals(CredentialType.SHARED_ACCOUNT_KEY) && sharedKey != null) {
    var keyB64 = FilesURIStrings.reconstructBase64EncodedValue(sharedKey);
    builder.credential(new StorageSharedKeyCredential(configuration.getAccount(), keyB64));
} else if (configuration.getCredentialType().equals(CredentialType.AZURE_SAS)) {
    builder = builder.sasToken(token.toURIQuery());
} else if (configuration.getCredentialType().equals(CredentialType.AZURE_IDENTITY)) {
    builder = builder.credential(new DefaultAzureCredentialBuilder().build());
} 

Issue Links

• links to: GitHub Pull Request #15727