[CAMEL-21256] camel-github startingSha=last does not work with large history

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.8.0
• Fix Version/s: 4.8.1, 4.9.0
• Component/s: camel-github
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Chris Slater
• Created: 24/Sep/24 18:17
• Updated: 26/Sep/24 14:34
• Resolved: 26/Sep/24 14:34

Description

I encountered an issue using startingSha=last with a repository with a large history.  The last sha is not correctly resolved.   CAMEL-17473 did not resolve this issue.  I am putting together a pull request with a possible solution.

 

The following issues were discovered from real-world testing and a unit test:

1. it appears that the first commit returned from the GitHub API is the most recent and the sha from that should be used as the lastSha variable.
2. There is a threading issue where CommitConsumer.poll() can be called concurrently with CommitConsumer.doStart().  In some situations lastSha can be null in the poll() method, producing the same behavior as startingSha=beginning, which is undesired.

 

 

Issue Links

• links to: GitHub Pull Request #15678