[CAMEL-20732] RestDefinition does not properly handle array of primitives for` in/out types

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.4.2
• Fix Version/s: 4.4.3, 4.6.0
• Component/s: camel-core
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Stefan Kalscheuer
• Created: 02/May/24 16:13
• Updated: 03/May/24 07:33
• Resolved: 03/May/24 07:33

Description

This is likely a regression from CAMEL-15199 (since 3.5.0).

Using primitive array types as in/out type in REST route definition results in invalid string representation of the actual type.

 

History

Noticed on a project with Camel 4.4 including SpringDoc and a route with outType "byte[]".
OpenAPI/Swagger output is completely broken (i.e. empty), apparently because the type "null[]" is not resolvable.

The issue is still present in latest 4.6.0-SNAPSHOT and most likely since 3.5.0

 

Analysis

The workaround code introduced in the referenced issue contains this branch:

if (!classType.isPrimitive()) {
    if (classType.isArray()) {
        type = StringHelper.between(classType.getName(), "[L", ";") + "[]";
    } else {
/* ...*/

Because byte[].class.getName() returns "[B" there is nothing betwen "[L" and ";", so the output is "null[]".

 

Example

package my.example;

public class MyRoutes extends org.apache.camel.builder.RouteBuilder {
    @Override
    public void configure() throws Exception {
        rest()
            .get("/test")
                .outType(byte[].class)
                .produces("application/octet-stream")
                .route()
                    .log("test me");
    }
} 

 

Workarounds

Use boxed type, e.g. Byte[] (which correctly results in "java.lang.Byte[]") or specify the type as String "byte[]" directly.

 

Solution

The solution seems pretty straight forward here. I will submit a proposal

Issue Links

• links to: GitHub Pull Request #14043