[CAMEL-20534] camel-grpc: Port validation should check if a port was specified

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.4.1, 4.5.0
• Component/s: camel-grpc
• Estimated Complexity: Unknown
• Assignee: James Netherton
• Reporter: James Netherton
• Created: 07/Mar/24 09:50
• Updated: 07/Mar/24 10:36
• Resolved: 07/Mar/24 10:36

Description

The gRPC docs are maybe a bit misleading because they state that the port part of the URI is mandatory.

However, it's currently possible to omit it and you then end up with either a consumer started on a random port (because the port int has the default value of 0). Or a producer that tries to connect to the gRPC default port.

So I propose to initialize the port with a default of -1 and fix up the validation logic as using isEmpty is not really appropriate in this case.

https://github.com/apache/camel/blob/7c8e7414e31f3eab888c7fb539abc8e5b3a61d6b/components/camel-grpc/src/main/java/org/apache/camel/component/grpc/GrpcConsumer.java#L96

Issue Links

• links to: GitHub Pull Request #13405
• links to: GitHub Pull Request #13406