[CAMEL-20457] camel-core - NullPointerException for Split parallel and timeout without AggregationStrategy

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.22.1
• Fix Version/s: 3.21.5, 3.22.2, 4.0.5, 4.4.1, 4.5.0
• Component/s: canel-core
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Manuel Shenavai
• Created: 23/Feb/24 10:40
• Updated: 24/Feb/24 16:34
• Resolved: 24/Feb/24 08:46

Description

When using split() without a aggregation strategy, a NPE will be thrown once the timeout has been exceeded.

Coming from Camel 2 we had not set any AggregationStrategy. With Camel 3 this timeout handling now requires a Aggregation Strategy. Either there should be a default AggregationStrategy or a Null-Check in MulticastProcessor$MulticastTask

Example:
https://github.com/apache/camel/blob/camel-3.22.x/core/camel-core/src/test/java/org/apache/camel/processor/SplitParallelTimeoutTest.java#L59

Remove the parameter MyAggregationStrategy and execute the test.

 

NullPointerException will be thrown:

Caused by: java.lang.NullPointerException: Cannot invoke "org.apache.camel.AggregationStrategy.timeout(org.apache.camel.Exchange, int, int, long)" because "strategy" is null
    at org.apache.camel.processor.MulticastProcessor$MulticastTask.timeout(MulticastProcessor.java:474)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:840)

 

For the multicast, there seems to be a default Aggregation Strategy. Maybe something similar can be done for the split?
https://github.com/apache/camel/blob/camel-3.22.x/core/camel-core-reifier/src/main/java/org/apache/camel/reifier/MulticastReifier.java#L118

Issue Links

• links to: GitHub Pull Request #13282