[CAMEL-20388] Salesforce component does not handshake on the connection failure - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 3.22.1
Fix Version/s: 3.21.5, 3.22.2, 4.0.5, 4.4.2, 4.6.0
Component/s: camel-salesforce
Labels:
None

Estimated Complexity:
Unknown

Description

We use the Salesforce component to consume platform events and every 3 hours we observe the following warning message:

Connect failure: {advice={reconnect=handshake, interval=0}, channel=/meta/connect, id=2005814, error=403::Unknown client, successful=false}

According to this article, it is caused by the expiring sfdc-stream cookie used by CometD. When it happens, the client is expected to perform a new handshake and re-subscribe to the channels. This is handled in connectListener (SubscriptionHelper#initMessageListeners). Unfortunately, because the client is in the CONNECTED state when this message is received, the condition

        while (!abort && !client.isDisconnected()) {
            try {
                Thread.sleep(DISCONNECT_INTERVAL);
            } catch (InterruptedException e) {
                LOG.error("Aborting handshake on interrupt!");
                abort = true;
            }

            abort = abort || isStoppingOrStopped();
        }

(SubscriptionHelper#doHandshake) is not met and it stays in the handshaking state indefinitely (SubscriptionHelper#handshaking), hence the handshake is not being performed. As a consequence, after a couple of days the client stops receiving Salesforce events.

This bug may have been introduced by this commit, which removed