[CAMEL-20349] camel-salesforce: ClassCastException when a request is retried after a 401

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.0
• Fix Version/s: 4.4.0
• Component/s: camel-salesforce
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Lorenzo Benvenuti
• Created: 19/Jan/24 10:19
• Updated: 25/Jan/24 14:15
• Resolved: 25/Jan/24 13:48

Description

Hi,

I've noticed an issue when camel-salesforce retries a request after a 401; the component is able to fetch another access token, but then an exception is thrown:

[SalesforceHttpClient@1d75e7af-24] INFO org.eclipse.jetty.client.ResponseNotifier - Exception while notifying listener org.apache.camel.component.salesforce.internal.client.AbstractClientBase$1@77a6eac7
java.lang.ClassCastException: class org.eclipse.jetty.client.HttpRequest cannot be cast to class org.apache.camel.component.salesforce.internal.client.SalesforceHttpRequest (org.eclipse.jetty.client.HttpRequest and org.apache.camel.component.salesforce.internal.client.SalesforceHttpRequest are in unnamed module of loader 'app')
	at org.apache.camel.component.salesforce.internal.client.AbstractClientBase$1.onComplete(AbstractClientBase.java:221)
	at org.eclipse.jetty.client.ResponseNotifier.notifyComplete(ResponseNotifier.java:213)
	at org.eclipse.jetty.client.ResponseNotifier.notifyComplete(ResponseNotifier.java:205)
	at org.eclipse.jetty.client.HttpReceiver.terminateResponse(HttpReceiver.java:492)
	at org.eclipse.jetty.client.HttpReceiver.terminateResponse(HttpReceiver.java:472)
	at org.eclipse.jetty.client.HttpReceiver.responseSuccess(HttpReceiver.java:435)
	at org.eclipse.jetty.client.http.HttpReceiverOverHTTP.messageComplete(HttpReceiverOverHTTP.java:386)
	at org.eclipse.jetty.http.HttpParser.handleContentMessage(HttpParser.java:586)
	at org.eclipse.jetty.http.HttpParser.parseContent(HttpParser.java:1727)
	at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:1556)
	at org.eclipse.jetty.client.http.HttpReceiverOverHTTP.parse(HttpReceiverOverHTTP.java:221)
	at org.eclipse.jetty.client.http.HttpReceiverOverHTTP.process(HttpReceiverOverHTTP.java:160)
	at org.eclipse.jetty.client.http.HttpReceiverOverHTTP.receive(HttpReceiverOverHTTP.java:91)
	at org.eclipse.jetty.client.http.HttpChannelOverHTTP.receive(HttpChannelOverHTTP.java:90)
	at org.eclipse.jetty.client.http.HttpConnectionOverHTTP.onFillable(HttpConnectionOverHTTP.java:194)
	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:314)
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:100)
	at org.eclipse.jetty.io.SelectableChannelEndPoint$1.run(SelectableChannelEndPoint.java:53)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.runTask(AdaptiveExecutionStrategy.java:421)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.consumeTask(AdaptiveExecutionStrategy.java:390)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.tryProduce(AdaptiveExecutionStrategy.java:277)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.run(AdaptiveExecutionStrategy.java:199)
	at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:411)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:969)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1194)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1149)
	at java.base/java.lang.Thread.run(Thread.java:833)

I've reproduced the error using a camel-salesforce test, RawPayloadTest. The test has been updated to return a 401 for the first request, and then return a 200 (I used a boolean for this, I'm not familiar with MockWebServer and IDK if it provides some API to implement a "state machine" like Wiremock). With these changes, the test hangs (see https://github.com/lorenzobenvenuti/camel/blob/reproduce-issue-4.1/components/camel-salesforce/camel-salesforce-component/src/test/java/org/apache/camel/component/salesforce/RawPayloadTest.java).

The same test works with version 4.4 (https://github.com/lorenzobenvenuti/camel/blob/reproduce-issue-4.4/components/camel-salesforce/camel-salesforce-component/src/test/java/org/apache/camel/component/salesforce/RawPayloadTest.java).

The discrepancy between 4.1 and 4.4 could be related to the changes made for CAMEL-20248, when SalesforceHttpRequest was removed.

Thanks,

lorenzo