[CAMEL-20131] camel-core - SetHeaders EIP some small things we can improve

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.3.0
• Fix Version/s: 4.3.0
• Component/s: camel-core, eip
• Estimated Complexity: Unknown
• Assignee: Karen Lease
• Reporter: Claus Ibsen
• Created: 20/Nov/23 12:29
• Updated: 22/Nov/23 21:11
• Resolved: 22/Nov/23 21:11

Description

Lets polish this a bit more

1) Java DSL to accept vanilla Map

from("direct:start").setHeaders(Map.of("a", 1, "b", 2, ...)).to("mock:result")

The current API is Map<String, Expression> which wont allow the above. But we need both kind, but not sure if we can just add Map<String, Object> and have both variants.

2)
I assume this method with the Expression as first argument is to force the Java DSL to then use expression builders easily. However maybe add some code comment why its this as we will forget in the future.

public Type setHeaders(String headerName, Expression expr, Object... headerNamesAndValues) {

3)
Add Map.of as example in the documentation

4)
Add YAML DSL for the examples where its missing

Issue Links

• is caused by: CAMEL-20056 camel-core - SetHeaders EIP to set multiple headers in a single EIP
• links to: GitHub Pull Request #12143