[CAMEL-19975] NIOConverter File to ByteBuffer conversion behavior is potentially non-deterministic

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0.2, 4.2.0
• Component/s: camel-core
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: James Netherton
• Created: 11/Oct/23 07:30
• Updated: 21/Oct/23 11:31
• Resolved: 21/Oct/23 11:30

Description

Maybe a bit of an edge case, but the result of NIOConverter.toByteBuffer(File) can potentially vary depending on the size of the file used for conversion. It can be null or a ByteBuffer with partial or empty content.

The converter does:

byte[] buf = new byte[(int) file.length()];

If file.length() > Integer.MAX_VALUE, then the cast from long to int can produce some unexpected results. E.g if the file size is Integer.MAX_VALUE + 1, then the result from the cast is -2147483648. If the file size is 4294967296 then the result from the cast is 0.