[CAMEL-19555] camel-spring: ensure tests have assertions

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.1.0
• Component/s: camel-spring, camel-spring-ws, camel-spring-xml, tests
• Labels: easy help-wanted
• Estimated Complexity: Novice
• Assignee: Otavio Rodolfo Piske
• Reporter: Otavio Rodolfo Piske
• Created: 28/Jun/23 08:55
• Updated: 05/Oct/23 15:19
• Resolved: 05/Oct/23 15:19

Description

Some tests do not have assertions and that prevents us from fully understanding what is a test failure and what is an error. In many cases, these are tests that were originally written with older versions of JUnit in mind (i.e: equal or older than v4), so they lack modernization.

 

We should ensure every test has an assertion. The assertion does not, necessarily, needs to be visible (i.e.: it can be called in a separate method).

 

When asserting that a piece of code does not throw an error, we should use JUnit's 5 assertDoesNotThrow (either the linked method or one of the others with different signatures).

 

 

Issue Links

• is a clone of: CAMEL-19550 camel-dhis: ensure tests have assertions
• links to: GitHub Pull Request #11653