[CAMEL-19399] camel-cxf - Prevent storing invalid entry in Converter cache on error

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.18.7, 3.20.4, 4.0-M3
• Fix Version/s: 3.18.8, 3.20.6, 3.21.0, 4.0-RC1
• Component/s: came-cxf
• Estimated Complexity: Unknown
• Assignee: Nicolas Filotto
• Reporter: Nicolas Filotto
• Created: 29/May/23 14:17
• Updated: 30/May/23 12:26
• Resolved: 30/May/23 12:26

Description

If an error occurs while converting a value thanks to the CxfPayloadConverter, the value null is returned to let other fallback converters to try but if there are no such fallback converters, the cache of converters will keep the information that no converter exists which is not incorrect.

The behavior described above occurs when the unit test CxfPayloadConverterTest#testInvalidByteArrayToCxfPayload is called before CxfPayloadConverterTest#testByteArrayToCxfPayload, in that case, Camel believes that there is no converter for a byte array so it returns null.

The corresponding failing test report https://ci-builds.apache.org/job/Camel/job/Camel%20JDK17/job/main/876/testReport/org.apache.camel.component.cxf.converter/CxfPayloadConverterTest/testByteArrayToCxfPayload/

Issue Links

• is caused by: CAMEL-19160 return null for CxfPayloadConverter fallback converter so that other fallback coverter can get a chance to try
• links to: GitHub Pull Request #10227
• links to: GitHub Pull Request #10230
• links to: GitHub Pull Request #10231
• links to: GitHub Pull Request #10232