[CAMEL-19234] camel-core - When looking up a mandatory bean, look it up through its type first

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0-M3, 4.0.0
• Component/s: camel-core
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Marco Bungart
• Created: 02/Apr/23 15:39
• Updated: 05/Apr/23 04:59
• Resolved: 05/Apr/23 04:59

Description

Currently, when we look up a mandatory bean which type we know, we perform the lookup with the bean's name and convert it to the requested type:

CamelContextHelper.java

...
public static <T> T mandatoryLookupAndConvert(CamelContext context, String name, Class<T> beanType) {
    Object value = lookup(context, name);
    if (value == null){
        throw new NoSuchBeanException(name, beanType.getName());
    }
    return convertTo(context, beanType, value);
}
...

Source: https://github.com/apache/camel/blob/main/core/camel-support/src/main/java/org/apache/camel/support/CamelContextHelper.java#L245

This leads to problem with the current implementation of https://github.com/apache/camel-quarkus/issues/4725, where we introduced automatic registration of beans annotated with @Identifier . When several beans with the same @Identifier("<name>") but different types are present. We think we can prevent this problem when we modify above method to do a lookup(...) with the type information, and only do the lookup(...) without type information if the lookup(...)with type information yielded no result.

FTR: relevant zulip chat

Issue Links

• relates to: CAMEL-11862 Convert to requested type values retrieved from the repository
• links to: GitHub Pull Request #9811