Camel
  1. Camel
  2. CAMEL-1882

Aggregator fails permanently if exception thrown from aggregation strategy

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0-M3
    • Fix Version/s: 2.0.0
    • Component/s: camel-core
    • Labels:
      None

      Description

      BatchSender thread in BatchProcessor doesn't expect any error thrown from Collection.add() method, so when it is thrown the whole thread dies and is never recovered. In Aggregator, where aggregation strategy exists such exceptions can be easily thrown from Collection.add() and can render Aggregator unusable.

        Activity

        Hide
        Roman Kalukiewicz added a comment -

        Fix in r801545

        The fix could be improved as errors are not handled using standard error handlers, but some error handler attached to BatchProcessor. I did it to fix the problem quickly. Moreover there is error handler already used in BatchProcessor, while I believe it should be removed at all and use standard error handler.

        Show
        Roman Kalukiewicz added a comment - Fix in r801545 The fix could be improved as errors are not handled using standard error handlers, but some error handler attached to BatchProcessor. I did it to fix the problem quickly. Moreover there is error handler already used in BatchProcessor, while I believe it should be removed at all and use standard error handler.
        Hide
        Roman Kalukiewicz added a comment -

        The problem also exists if exception is thrown from correlation expression - not only from aggregation strategy. The fix that is commited already also handles this scenario.

        Show
        Roman Kalukiewicz added a comment - The problem also exists if exception is thrown from correlation expression - not only from aggregation strategy. The fix that is commited already also handles this scenario.

          People

          • Assignee:
            Roman Kalukiewicz
            Reporter:
            Roman Kalukiewicz
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development