[CAMEL-18739] ZipAggregationStrategy loses onCompletion

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.19.0
• Fix Version/s: 3.20.0
• Component/s: camel-zipfile
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Alexander Lex
• Created: 21/Nov/22 12:52
• Updated: 14/Dec/22 18:00
• Resolved: 14/Dec/22 18:00

Description

We are facing an issue where we end up with stale files in the temp directory (on Windows: C:\Users\...\AppData\Local\Temp). This stops our application from running.

 

Problem description:

When using "Split Definition" with "ZipAggregationStrategy", we try to aggregate multiple parts in one zip archive. Our Code does exactly that and works fine, but it misses the step to delete the temporaly created archive (created automactly) in the temp directory after completion.

 

We would expect that the completion of the route does the deletion.

 

Having a look in into the code, we saw that the "ZipAggregationStrategy" does have a "DeleteZipFileOnCompletion", which does exactly that. The "OnCompletion" is also added to the exchange. However,  the deletion is never executed, due to a copy of the subexchange to the original exchange (losing the previously added onComplete)

 

Attached you can find code to reproduce the issue.

 

Issue Links

• links to: GitHub Pull Request #8795