Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-18516

camel-yaml-dsl - bannedDefinitions doesn't work for generate-yaml-schema

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.20.0
    • camel-yaml-dsl, tooling
    • None
    • Unknown

    Description

       GenerateYamlSchemaMojo here retrieves deserializers and extract the corresponding definitions from it, causes to bypass the bannedDefinitions check
      https://github.com/apache/camel/blob/f7d1282261013f0172e90a3ddaa4fd0f1b1d6a94/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/GenerateYamlSchemaMojo.java#L87
       
      It would need a separate check with `isBanned()` against extracted *Definition.
      Due to this issue, the current generated schema has `FromDefinition` while it's listed as banned in POM

      https://github.com/apache/camel/blob/f7d1282261013f0172e90a3ddaa4fd0f1b1d6a94/dsl/camel-yaml-dsl/camel-yaml-dsl/src/generated/resources/schema/camel-yaml-dsl.json#L1013

      Attachments

        Activity

          People

            igarashitm Tomohisa Igarashi
            igarashitm Tomohisa Igarashi
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: