[CAMEL-17705] Camel Salesforce - Http Client timeout is hardcoded

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.14.0, 3.15.0
• Fix Version/s: 3.17.0
• Component/s: camel-salesforce
• Estimated Complexity: Unknown
• Assignee: Jeremy Ross
• Reporter: Jawad Ahmad
• Created: 23/Feb/22 17:15
• Updated: 01/Apr/22 02:03
• Resolved: 26/Mar/22 14:52

Description

I am using Bulk V2 API to upload large files to Salesforce. I have noticed that on creating the job from Producer it times out with Timeout exception. I tried to change the timeout configuration but noticed its always gets set to a hardcoded one.

Class : SalesforceComponent

static SalesforceHttpClient createHttpClient(
            Object source, final SslContextFactory sslContextFactory, final CamelContext context, int workerPoolSize,
            int workerPoolMaxSize) {
        SecurityUtils.adaptToIBMCipherNames(sslContextFactory);

        final SalesforceHttpClient httpClient = new SalesforceHttpClient(
                context, context.getExecutorServiceManager().newThreadPool(source, "SalesforceHttpClient", workerPoolSize,
                        workerPoolMaxSize),
                sslContextFactory);
        // default settings, use httpClientProperties to set other
        // properties
        httpClient.setConnectTimeout(CONNECTION_TIMEOUT);
        httpClient.setIdleTimeout(IDLE_TIMEOUT);

        return httpClient;
    }

As suggested by Claus to use httpClientProperties. In that case, HTTP client does set the connection timeout of the configured value. But it passes timeout value to SalesforceSession instead of ConnectionTimeout value. So it still gets failed with a Timeout error.

Class : SalesforceComponent
Method: doStart

 setupHttpClient(httpClient, getCamelContext(), httpClientProperties);
// support restarts
if (session == null) {
session = new SalesforceSession(getCamelContext(), httpClient, httpClient.getTimeout(), loginConfig);
        }